<br>
<div><span class="gmail_quote">2008/6/2, Nick Mathewson <<a href="mailto:nickm@freehaven.net">nickm@freehaven.net</a>>:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">On Sun, Jun 01, 2008 at 01:51:53PM +0800, liusifan wrote:<br>[...]<br><br>This seems pretty promising, and could wind up being a better<br>
short-term idea than our older plan to get IOCP support by making it a<br>new backend for bufferevents.<br><br>How well tested is this? Can you get the unit tests to pass, at<br>least, to the extent that the unit tests in 1.4.4 currently pass on<br>
win32? I'd like people who use libevent on windows to try this code<br>out; if it works well, we should integrate it.</blockquote>
<div> </div>
<div> </div>
<div>Do you mean the uni tests in libevent/test directory ?</div>
<div>I will try to get these unit tests to pass. </div>
<div> </div>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">(For future reference, please use unified diffs (generated with diff -u)<br>rather than old-style diffs. They're shorter and (usually) easier<br>
to read. This diff is small enough that there's not much worry<br>about this one, though.)</blockquote>
<div> </div>
<div>OK, will use -u option.</div>
<div> </div><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">> add file : libevent-1.4.4-iocp\WIN32-Code\win32iocp.cpp<br> ^^^^ You mean ".c"?</blockquote>
<div> </div>
<div>Yes. Just a type mistake. It's win32iocp.c .</div>
<div> </div><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Hm. This might be better applied against trunk (which will eventually<br>become libevent 2.0) than against 1.4.4; the 1.4 series is supposed to<br>
be stable, and Big New Features are usually out there...<br><br>...but now that I look at the code, it looks like the only big change<br>is to add a new backend file, which (as far as I can tell) doesn't<br>require any big changes elsewhere in the code. I'd be curious to see<br>
what Niels thinks here, but I wouldn't be opposed to checking it into<br>the stable branch.</blockquote>
<div> </div>
<div>These some thing i need to explain here.</div>
<div> </div>
<div>This patch requires to add a EV_ACCEPT macro to indicate the </div>
<div>accept event. This is incompatible with the old code. The old code use</div>
<div>EV_READ to indicate the accept event. </div>
<div> </div>
<div>Best Regards,</div>
<div> </div>
<div>Stephen Liu</div></div><br>