[Libevent-users] [patch] replace linear search in evdns with hashed list and add support of listening on unix sockets for evhttp

Nick Mathewson nickm at freehaven.net
Thu Apr 17 14:51:04 EDT 2008


On Mon, Feb 18, 2008 at 06:58:32PM +0300, Vsevolod Stakhov wrote:
 [...]
> >I've made some modifications to patch to attract your wishes, thought 
> >I've not tested it in production yet.
> 
> Sorry, attached reversed diff.
> 

Hi, and sorry about the delay!  Now that libevent 1.4 is stable, I'm
able to spend more time getting more patches into the next series.  I
did a match to make evdns.c threadsafe, but after I did so your patch
no longer applied cleanly.  I've done an updated version of your patch
and attached it here; could you test it out and let me know if it
works for you and does what you want under load?

You'll need to apply it to svn trunk; it won't work with 1.4.

I'm still curious whether evdns_transmit() shows up on your profiles:
it's the only remaining common case where we walk the list of all
inflight requests.  As you said before, your patch shouldn't make it
any slower, but I'm curious whether it appears slow for you at all.
If so, there should be another list of requests for which transmit_me
is set, so we don't need to walk the whole list of inflight requests
just in order to retry those.

yrs,
-- 
Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: evdns_multihead.diff
Type: text/x-diff
Size: 10545 bytes
Desc: not available
Url : http://monkeymail.org/archives/libevent-users/attachments/20080417/539bf30c/evdns_multihead-0001.bin


More information about the Libevent-users mailing list