[Libevent-users] Re: Six patches for evdns.c
Niels Provos
provos at citi.umich.edu
Mon May 28 17:22:26 EDT 2007
I submitted the rest of the patches to the subversion repository.
Thank you again,
Niels.
On 5/28/07, Niels Provos <provos at citi.umich.edu> wrote:
> On 5/28/07, Nick Mathewson <nickm at freehaven.net> wrote:
> > 02-no-timeout-on-failure.diff
> >
> > As written, when a nameserver fails quickly, we would set a timeout
> > and not actually acknowledge the failure until the timeout had
> > elapsed. This isn't necessary, and tended to delay actual retries
> > unnecessarily. [I'd appreciate review on this one.]
>
> We need a test for this one. It looks like the main difference is
> that the timeout is no longer added. However, many callers of
> evdns_request_transmit seem to ignore the return code. So, it seems
> that the whoever made the dns request might never get the callback.
>
> Niels.
>
More information about the Libevent-users
mailing list