[Libevent-users] [PATCH] fixes for better Solaris support

[Harry Kao]

On Fri, May 04, 2007 at 08:21:08AM +0200, Wouter Wijngaards wrote:
> Hi Harry,
> 
> I looked over your patch.
> * perhaps you should have configure detect __inline or inline. Some
> platforms do not understand plain 'inline' I believe.

configure.in already calls AC_C_INLINE, which should define "inline"
to whatever keyword the compiler uses for that feature, or nothing if
it is unsupported.

> * the volatile keyword is needed because the signal handler sets this
> variable, then wakes up the eventloop. The eventloop reads the variable.
> Thus this variable is volatile for the eventloop, since a signal handler
> can change it at any time. Could you please add it back.

You're right, sorry about that.  I didn't realize that variables
accessed in a signal handler required "volatile."  Here's an updated
patch.

Harry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solaris.diff
Type: text/x-diff
Size: 15706 bytes
Desc: not available
Url : http://monkeymail.org/archives/libevent-users/attachments/20070503/4ca22839/solaris.bin