[Libevent-users] [PATCHES] use monotonic clock & infinite timeouts

[Niels Provos]

Thanks for the patches.  I removed the default timeout.  Your patch
had a bug where timeout_correct no longer set event_tv correctly.  I
fixed that.  Unfortunatley, the regression test currently fails on Mac
OS X when compiled with -O2.  Still trying to figure that one out.

Niels.

On 7/25/07, Scott Lamb <slamb at slamb.org> wrote:
> Scott Lamb wrote:
> > libevent's monotonic clock detection is currently broken on all
> > platforms. The first attached patch fixes it. The second takes advantage
> > of it to remove the 5-second idle timeout where possible.
>
> Actually, I don't think I understand the purpose of this timeout at all.
> I had thought it was to make some effort to adjust the timeout values if
> the system clock gets set backwards (related to timeout_correct()). But
> for that to make any sense, it'd have to be a limit on the time to wait
> when there are longer timeouts. Instead, it's a time to wait when
> there's no timeout scheduled at all.
>
> I don't think it accomplishes anything. Maybe the default timeout should
> be removed entirely, not just if a monotonic clock is available?
>
> Best regards,
> Scott
>
> --
> Scott Lamb <http://www.slamb.org/>
>
>